HHH-12997 Throwing custom exception when using @JoinFormula along with @OneToMany #3381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
I don't know why but the indentation was messed up. I mannually fixed it.
Member
|
Thanks, this was a good idea; superseded by #9320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a custom exception when failing to parse column as formula.
This annotation combination is not supported yet, even if there are plans to add support to it and some colaborators agree this is a convinient feature to add support to.
Steve Ebersole added a test to keep track of an error that ocurred previously when trying this, but now this exception is thrown. Anyway, if It is not going to be done in a short term, in my opinion there should be a custom exception being thrown.
Previous exception:
java.lang.ClassCastException: org.hibernate.mapping.Formula cannot be cast to org.hibernate.mapping.ColumnNew exception:
org.hibernate.AnnotationException: Formula is not supported along with this type of relationshipAlso added a test with
@FaliureExpectedin order to extend the track of the use case.