Skip to content

HHH-14519 More informative error message for bad logical column name #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

HHH-14519 More informative error message for bad logical column name #3853

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aad5112
HHH-14519 More informative error message for bad logical column name
karge-itestra Feb 24, 2021
fc3d629
Update hibernate-core/src/main/java/org/hibernate/boot/internal/InFli…
gavinking Nov 24, 2024
1b098eb
Merge branch '5.6' into HHH-14519
gavinking Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions hibernate-core/src/main/java/org/hibernate/boot/internal/InFlightMetadataCollectorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,15 +981,20 @@ public void addColumnNameBinding(Table table, Identifier logicalName, Column col

@Override
public String getPhysicalColumnName(Table table, String logicalName) throws MappingException {
return getPhysicalColumnName( table, getDatabase().toIdentifier( logicalName ) );
Identifier logicalColumnIdentifier = getDatabase().toIdentifier(logicalName);
if (logicalColumnIdentifier == null) {
throw new MappingException( String.format(
Locale.ENGLISH,
"Column with logical name \"[%s]\" in table [%s] cannot be mapped to column identifier.",
logicalName,
table.getName()
) );
}
return getPhysicalColumnName( table, logicalColumnIdentifier);
}

@Override
public String getPhysicalColumnName(Table table, Identifier logicalName) throws MappingException {
if ( logicalName == null ) {
throw new MappingException( "Logical column name cannot be null" );
}

Table currentTable = table;
String physicalName = null;

Expand Down