HHH-16352 - Dynamic mutations and batching #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

sebersole wants to merge 2 commits into hibernate:main from sebersole:batching

Member

sebersole commented Mar 28, 2023

2 tests in 2 commits. The first commit is also included in jrenaat#31

sebersole added 2 commits

March 27, 2023 17:21


          HHH-16352 - Dynamic mutations and batching

cdf8bd6


          HHH-16352 - Dynamic mutations and batching

377efb2

hibernate-github-bot bot commented Mar 28, 2023 •

edited

Loading

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

sebersole changed the title ~~Batching~~ HHH-16352 - Dynamic mutations and batching

github-advanced-security bot found potential problems

View reviewed changes

hibernate-core/src/test/java/org/hibernate/orm/test/batch/GeneratedValuesWithBatchingTests.java

+              	}
+              	public static class DatabaseCreationTimestampGeneration extends AbstractDatabaseTimestampGenerator<DatabaseCreationTimestamp> {
+              		public GenerationTiming getGenerationTiming() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ValueGeneration.getGenerationTiming](1); it is advisable to add an Override annotation.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/GeneratedValuesWithBatchingTests.java

+              	}
+              	public static class DatabaseUpdateTimestampGeneration extends AbstractDatabaseTimestampGenerator<DatabaseCreationTimestamp> {
+              		public GenerationTiming getGenerationTiming() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ValueGeneration.getGenerationTiming](1); it is advisable to add an Override annotation.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/GeneratedValuesWithBatchingTests.java

+              			// nothing to do
+              		}
+              		public ValueGenerator<?> getValueGenerator() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ValueGeneration.getValueGenerator](1); it is advisable to add an Override annotation.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/GeneratedValuesWithBatchingTests.java

+              			return true;
+              		}
+              		public String getDatabaseGeneratedReferencedColumnValue() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ValueGeneration.getDatabaseGeneratedReferencedColumnValue](1); it is advisable to add an Override annotation.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/GeneratedValuesWithBatchingTests.java

+              	}
+              	public static abstract class AbstractDatabaseTimestampGenerator<A extends Annotation> implements AnnotationValueGeneration<A> {
+              		public boolean referenceColumnInSql() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [ValueGeneration.referenceColumnInSql](1); it is advisable to add an Override annotation.

Member Author

sebersole commented Mar 28, 2023

Included in #6310

sebersole closed this

sebersole deleted the batching branch

March 28, 2023 12:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet