[Envers] HHH-17652 Fix NullPointerException when mapping audited many-to-one relationships #7715
Conversation
…elationships fixes b384b37
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
csaadaam
changed the title
gavinking
changed the title
mbellade
left a comment
mbellade
left a comment
There was a problem hiding this comment.
@csaadaam thank you for your contribution! Sorry for taking so long, we have a long backlog of issues and we're trying to get to pending PRs.
I've left a small comment about code style, but other than that, your change looks reasonable to me. I would ask you to please include a test in your PR which ensures the NPE has been fixed by your changes and prevents us from re-introducing a regression in the future.
| if (referencedEntity.isAudited()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Please follow our code style guidelines.
| if (referencedEntity.isAudited()) { | |
| return false; | |
| } | |
| if ( referencedEntity.isAudited() ) { | |
| return false; | |
| } |
|
We're also in the process or investigating a move to the Apache Software License v2. If you agree with allowing this change to be relicensed under that license, please add this text to the subject - By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license |
|
@csaadaam I took the liberty of looking into this issue and found that while your solution resolved the problem with your use-case it caused errors in several envers tests verifying the correct functionality of audited entities using not-found relationships. I've added a test case and proposed a working fix here: #9453 |
@mbladel Thank you very much for looking into it and fixing it! |
2 participants
fixes b384b37
https://hibernate.atlassian.net/browse/HHH-17652