-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18461 Fix native query doesn't respect query.setFirstResult(0)
#8750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
177c6c0 to
7dd5419
Compare
gavinking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the motivation behind this.
|
Comment from @beikov :
|
|
Fine, then I'll let Christian make the call on this. To me it seems weird to change the SQL that was handwritten by the user if we don't absolutely need to, but whatever, it's fine. |
|
@beikov Please make the call. |
beikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the change looks good to me. Please rebase and then we can merge it.
Align to JPQL query, generated sql should contain `offset ? rows` and pass `0` as parameter.
Rebased. |
Align to JPQL query, generated sql should contain
offset ? rowsand pass0as parameter.[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18461