-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18513 fix wrong prePartialFlush calculation in Session Metrics log #8820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-18513 fix wrong prePartialFlush calculation in Session Metrics log #8820
Conversation
|
It seems that there was an error in the database setup for the oracle test. The tests fail with a "cannot connect to database" error (which also seems unrelated to the proposed change): There was also an error during the "Start database" task: Is this a temporary/flaky error in the oracle database setup? If so, could you please retry the build job? Apparently, I don't have the rights to do so. |
.../src/test/java/org/hibernate/engine/internal/StatisticalLoggingSessionEventListenerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/hibernate/engine/internal/StatisticalLoggingSessionEventListenerTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @boskoop , apart the couple of comments on the test the PR looks good to me. |
- remove checks for count values - improve failure message for number of logged lines
|
@dreab8 sorry for the delay as I have been on vacation for a bit.. Could you please check again? I tried to improve the PR based on your feedback. |
|
Thanks @boskoop |
| assertThat( sumDuration ).isLessThanOrEqualTo( sessionNanoDuration ); | ||
| } | ||
|
|
||
| private SessionMetric extractMetric(String logMessage, String regex) { |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
| assertThat( sumDuration ).isLessThanOrEqualTo( sessionNanoDuration ); | ||
| } | ||
|
|
||
| private SessionMetric extractMetric(String logMessage, String regex) { |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note test
|
squashed in on commit and applied manually. |
HHH-18513: Session Metrics for pre-partial-flushes are wrong
StatisticalLoggingSessionEventListenerwas incorrectly calculating the pre-partial-flush duration (probably due to a variable typo that passed review in commit e4e26ee).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.