HHH-18551 Fix memory leak caused by creation of new BasicTypeImpl

[gildur]

HHH-18551 Fix memory leak caused by creation of new BasicTypeImpl on every call to getRecommendedJdbcType

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[quaff]

BasicTypeImpl should implements hashCode/equals also.

[gildur]

BasicTypeImpl should implements hashCode/equals also.

Every instance of BasicTypeImpl have different name:

	private static int count;

	private final String name;

	public BasicTypeImpl(JavaType<J> jtd, JdbcType std) {
		super( std, jtd );
		name = String.format(
				Locale.ROOT,
				"%s@%s(%s,%s)",
				EXTERNALIZED_PREFIX,
				++count,
				jtd.getJavaTypeClass().getName(),
				std.getDefaultSqlTypeCode()
		);
	}

so implementing equals/hashCode with name included would not make any difference.

[quaff]

BasicTypeImpl should implements hashCode/equals also.

Every instance of BasicTypeImpl have different name:

	private static int count;

	private final String name;

	public BasicTypeImpl(JavaType<J> jtd, JdbcType std) {
		super( std, jtd );
		name = String.format(
				Locale.ROOT,
				"%s@%s(%s,%s)",
				EXTERNALIZED_PREFIX,
				++count,
				jtd.getJavaTypeClass().getName(),
				std.getDefaultSqlTypeCode()
		);
	}

so implementing equals/hashCode with name included would not make any difference.

I don't understand why they must have different names if JavaType and JdbcType are same, maybe equals/hashCode should exclude name.

[gildur]

@beikov Please review

[beikov]

Can you please also replace the construction of BasicType with resolving in?

• org.hibernate.sql.exec.internal.AbstractJdbcParameter#createEnumType
• org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder#resolveInferredType

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[beikov]

Please rebase and squash to a single commit.