Informix tests fixes #8874
Informix tests fixes #8874
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
|
I'm not sure we want to spread special cases across the main test suite for a community-supported dialect. |
hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/FunctionTests.java
Outdated
Show resolved
Hide resolved
VladoKuruc
force-pushed
the
informix_tests
branch
from
49b5951 to
9a915dc
Compare
VladoKuruc
force-pushed
the
informix_tests
branch
from
9a915dc to
b5fa9b2
Compare
I believe it is legitimate for tests to also consider community dialects. Especially if the database is also available in Docker and it is documented in the README. What do you think about that @beikov ?" |
|
I suggest including community dialect tests in CI build, but configured to allow the build to continue even if these tests fail. This would enable to monitor the evolution of dialect support and detect regressions without jeopardizing the overall CI process. |
|
@VladoKuruc as I already said, your PR looks fine but I'm reluctant to special-case community dialects in the core test suite. Also, testing community-supported dialects is up to the user / vendor that maintains them and using CI would consume resources. However, I can bring this up with the team and see what they think of it. Note: you can just skip the failing tests locally while they are not yet implemented / supported by the dialect you're testing |
hibernate-core/src/test/java/org/hibernate/orm/test/type/UUIDTypeConverterTest.java
Show resolved
Hide resolved
...rnate-core/src/test/java/org/hibernate/orm/test/id/uuid/sqlrep/sqlbinary/UUIDBinaryTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/array/PrimitiveByteArrayIdTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/annotations/entity/Forest.java
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/jpa/criteria/QueryBuilderTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/query/CteTests.java
Outdated
Show resolved
Hide resolved
VladoKuruc
force-pushed
the
informix_tests
branch
from
b5fa9b2 to
81432c5
Compare
VladoKuruc
force-pushed
the
informix_tests
branch
from
81432c5 to
449fa85
Compare
Backport of hibernate#8874
Backport of hibernate#8874
Backport of hibernate#8874
Backport of hibernate#8874
3 participants
Fixes for some of the Informix tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.