Enable Spotless #8952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gavinking merged 7 commits into hibernate:main from gavinking:spotless

Sep 16, 2024

Member

gavinking commented Sep 14, 2024

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

hibernate-github-bot bot commented Sep 14, 2024 •

edited

Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ Contribution — JIRA issues
↳ Failed with exception org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/hibernate/hibernate-orm/commits/59731c089e9d649a663c81d9622b54557d6aba37 {"message":"Not Found","documentation_url":"https://docs.github.com/rest/commits/commits#get-a-commit","status":"404"}

› This message was automatically generated.

gavinking changed the title ~~cleanups by spotless~~ Enable Spotless

github-advanced-security bot found potential problems

View reviewed changes

hibernate-core/src/main/java/org/hibernate/QueryParameterException.java

    
              	 * @param message The message explaining the exception condition

              	 */

              	public QueryParameterException(String message) {

              		super( message );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [QueryException.QueryException](1) should be avoided because it has been deprecated.

gavinking mentioned this pull request

HHH-15942 introduce ForcedFlushMode #5851

Closed

yrodiere requested changes

View reviewed changes

Member

yrodiere left a comment

Putting on hold until we figure out how to make this consistent with the auto-formatter on Search/Validator.
Maybe there's nothing to do, but let's at least check.

gavinking force-pushed the spotless branch from e42b34a to 5c131dd Compare

September 16, 2024 09:07

github-advanced-security bot found potential problems

View reviewed changes

...test/java/org/hibernate/community/dialect/functional/cache/SQLFunctionsInterSystemsTest.java

    
              		assertTrue( test.getDate1().equals(testvalue));

              		test = (TestInterSystemsFunctionsClass) s2.byId( TestInterSystemsFunctionsClass.class ).with( LockOptions.NONE ).load( 10L );

              		assertTrue( test.getDate1().equals(testvalue));

              		Date value = (Date) s2.createQuery( "select nvl(o.date,o.dateText) from TestInterSystemsFunctionsClass as o" )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Session.createQuery](1) should be avoided because it has been deprecated.

...test/java/org/hibernate/community/dialect/functional/cache/SQLFunctionsInterSystemsTest.java

    
                      assertTrue( value.equals(testvalue));

                      Object nv = s2.createQuery( "select nullif(o.dateText,o.dateText) from TestInterSystemsFunctionsClass as o" )

              		assertTrue( value.equals(testvalue));

              		Object nv = s2.createQuery( "select nullif(o.dateText,o.dateText) from TestInterSystemsFunctionsClass as o" )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Session.createQuery](1) should be avoided because it has been deprecated.

...test/java/org/hibernate/community/dialect/functional/cache/SQLFunctionsInterSystemsTest.java

    
                      assertTrue( dateText.equals("1977-07-03"));

                      value = (Date) s2.createQuery( "select ifnull(o.date,o.date1) from TestInterSystemsFunctionsClass as o" )

              		assertTrue( dateText.equals("1977-07-03"));

              		value = (Date) s2.createQuery( "select ifnull(o.date,o.date1) from TestInterSystemsFunctionsClass as o" )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Session.createQuery](1) should be avoided because it has been deprecated.

...test/java/org/hibernate/community/dialect/functional/cache/SQLFunctionsInterSystemsTest.java

    
                      assertTrue( value.equals(testvalue));

                      value = (Date) s2.createQuery( "select ifnull(o.date3,o.date,o.date1) from TestInterSystemsFunctionsClass as o" )

              		assertTrue( value.equals(testvalue));

              		value = (Date) s2.createQuery( "select ifnull(o.date3,o.date,o.date1) from TestInterSystemsFunctionsClass as o" )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Session.createQuery](1) should be avoided because it has been deprecated.

...test/java/org/hibernate/community/dialect/functional/cache/SQLFunctionsInterSystemsTest.java

    
                      assertTrue(pos.intValue() == 6);

                      String st = (String) s2.createQuery( "select convert(o.date1, SQL_TIME) from TestInterSystemsFunctionsClass as o" )

              		assertTrue(pos.intValue() == 6);

              		String st = (String) s2.createQuery( "select convert(o.date1, SQL_TIME) from TestInterSystemsFunctionsClass as o" )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Session.createQuery](1) should be avoided because it has been deprecated.

gavinking added 7 commits

September 16, 2024 19:30


          cleanups by spotless

59731c0


          enable spotless

83ac160


          disable checkstyle because we have spotless now

de3b8ed


          spaces to tabs!

4d63ffd


          indentWithTabs

077527c


          abbreviated source header

a6d1c67


          update checkstyle rule

66ce00f

gavinking force-pushed the spotless branch from 8089e31 to 66ce00f Compare

September 16, 2024 17:31

Member Author

gavinking commented Sep 16, 2024

This now implements the suggestions made by @yrodiere. I'm going to merge it soon, because it's a PITA to resolve conflicts in such a massive commit.

sebersole approved these changes

View reviewed changes

gavinking merged commit bcde12c into hibernate:main

gavinking deleted the spotless branch

September 17, 2024 06:43

mbellade mentioned this pull request

Exclude target folder from spotless to fix gradle compilation cache and add git blame ignore list #8965

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet