Skip to content

Conversation

@dreab8
Copy link
Member

@dreab8 dreab8 commented Sep 18, 2024

https://hibernate.atlassian.net/browse/HHH-18628


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@dreab8 dreab8 requested a review from beikov September 18, 2024 09:25
Copy link
Member

@mbellade mbellade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the check was forgotten while refactoring but let's hear from @beikov maybe there was a reason for it. Left a couple minor nitpicks.

Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the impact of the change on various queries and it all works fine. Thanks!

@dreab8
Copy link
Member Author

dreab8 commented Sep 20, 2024

Thanks @mbladel @beikov

@dreab8 dreab8 merged commit fccbb8d into hibernate:main Sep 23, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants