Skip to content

Conversation

@marschall
Copy link
Contributor

Add an ´IF EXISTS´ to the DROP TYPE and DROP FUNCTION statements in OracleUserDefinedTypeExporter if the dialect supports it (23+ .)

https://hibernate.atlassian.net/browse/HHH-18657


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marschall
Copy link
Contributor Author

One of the Oracle builds fails with

oracle.net.ns.NetException: ORA-12514: Cannot connect to database. Service freepdb1 is not registered with the listener at host localhost port 1521. (CONNECTION_ID=cf0HirgGQ/6F/E1LvtRxnQ==)
                https://docs.oracle.com/error-help/db/ora-12514/

I don't think this is related. Rather it looks to me as if a container is not yet started. Is there ar way to re-run this build?

@gavinking
Copy link
Member

I don't think this is related.

Very unlikely to be related.

Is there ar way to re-run this build?

I restarted it.

@marschall
Copy link
Contributor Author

I restarted it.

Thanks. It's green now.

@beikov beikov merged commit 7ffd991 into hibernate:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants