Skip to content

HHH-18662 Attribute not mentioned in orm.xml ends up not being mapped in Hibernate ORM 7 #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024
Merged

HHH-18662 Attribute not mentioned in orm.xml ends up not being mapped in Hibernate ORM 7 #9004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1e5805
HHH-18662 Add test for issue
dreab8 Sep 23, 2024
5dd7b1a
HHH-18662 Attribute not mentioned in orm.xml ends up not being mapped…
dreab8 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...rnate-core/src/main/java/org/hibernate/boot/models/xml/internal/ManagedTypeProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public static void processCompleteEntity(
classDetails.forEachPersistableMember( memberDetails -> {
final MutableMemberDetails mutableMemberDetails = (MutableMemberDetails) memberDetails;
mutableMemberDetails.clearAnnotationUsages();
mutableMemberDetails.addAnnotationUsage( JpaAnnotations.TRANSIENT.createUsage( xmlDocumentContext.getModelBuildingContext() ) );
} );
}

Expand Down Expand Up @@ -720,7 +719,6 @@ private static void adjustCompleteNonDynamicTypeMember(
MutableMemberDetails memberDetails,
JaxbPersistentAttribute jaxbAttribute,
XmlDocumentContext xmlDocumentContext) {
memberDetails.removeAnnotationUsage( JpaAnnotations.TRANSIENT );
CommonAttributeProcessing.applyAttributeAccessor(
jaxbAttribute,
memberDetails,
Expand Down
9 changes: 5 additions & 4 deletions ...e/src/test/java/org/hibernate/orm/test/boot/models/xml/complete/CompletePartialTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import org.hibernate.testing.orm.junit.ServiceRegistryScope;
import org.junit.jupiter.api.Test;


import jakarta.persistence.Transient;

import static org.assertj.core.api.Assertions.assertThat;
Expand All @@ -44,13 +45,13 @@ void testSourceModel(ServiceRegistryScope registryScope) {
final ClassDetailsRegistry classDetailsRegistry = sourceModelBuildingContext.getClassDetailsRegistry();
final ClassDetails classDetails = classDetailsRegistry.getClassDetails( Thing.class.getName() );

// NOTE : `#createBuildingContext` applies `XmlProcessor`, so `@Transient` handling is applied...
// NOTE : `#createBuildingContext` applies `XmlProcessor`

assertThat( classDetails.getFields() ).hasSize( 3 );
classDetails.forEachField( (i, fieldDetails) -> {
assertThat( fieldDetails.isPersistable() ).isTrue();
final boolean expectTransient = fieldDetails.getName().equals( "somethingElse" );
assertThat( fieldDetails.hasDirectAnnotationUsage( Transient.class ) ).isEqualTo( expectTransient );
assertThat( fieldDetails.hasDirectAnnotationUsage( Transient.class ) ).isFalse();

} );
}

Expand All @@ -60,6 +61,6 @@ void testSourceModel(ServiceRegistryScope registryScope) {
public void testBootModel(DomainModelScope domainModelScope) {
final PersistentClass entityBinding = domainModelScope.getEntityBinding( Thing.class );
assertThat( entityBinding.getIdentifierProperty().getName() ).isEqualTo( "id" );
assertThat( entityBinding.getProperties().stream().map( Property::getName ) ).containsOnly( "name" );
assertThat( entityBinding.getProperties().stream().map( Property::getName ) ).contains( "name" ).contains( "somethingElse" );
}
}
1 change: 1 addition & 0 deletions hibernate-core/src/test/resources/mappings/models/dynamic/dynamic-id-class.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<attributes>
<id name="name"/>
<id name="number"/>
<transient name="addresses"/>
</attributes>
</entity>
</entity-mappings>
Loading