Skip to content

Conversation

@beikov
Copy link
Member

@beikov beikov commented Sep 25, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18730
https://hibernate.atlassian.net/browse/HHH-18661

@beikov beikov changed the title HHH-18661 Add support for table valued functions HHH-18661 Add support for set-returning functions Sep 25, 2024
return "[]";
}
final StringBuilder sb = new StringBuilder();
final JsonAppender jsonAppender = new JsonAppender( sb );

Check warning

Code scanning / CodeQL

Potential output resource leak Warning

This JsonAppender is not always closed on method exit.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@beikov beikov force-pushed the HHH-18661 branch 2 times, most recently from 449273a to 6c3479f Compare October 10, 2024 16:36
@beikov beikov force-pushed the HHH-18661 branch 3 times, most recently from ae7a098 to 1e5ba2f Compare October 15, 2024 12:29
addIdColumns( embeddableModelPart, idColumns );
}
else {
throw new QueryException( "Unsupported model part container: " + modelPartContainer );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
QueryException.QueryException
should be avoided because it has been deprecated.
}

private String determineIndexSelectionExpression(SelectableMapping[] selectableMappings, String tableIdentifierVariable, TypeConfiguration typeConfiguration) {
final String defaultOrdinalityColumnName = typeConfiguration.getSessionFactory().getJdbcServices()

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
TypeConfiguration.getSessionFactory
should be avoided because it has been deprecated.
return visitTableGroup( resolved, sqmRoot );
}

throw new InterpretationException( "SqmFunctionRoot not yet resolved to TableGroup" );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
InterpretationException.InterpretationException
should be avoided because it has been deprecated.
return visitTableGroup( existing, sqmJoin );
}

throw new InterpretationException( "SqmFunctionJoin not yet resolved to TableGroup" );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
InterpretationException.InterpretationException
should be avoided because it has been deprecated.
Comment on lines +4464 to +4468
throw new SemanticException(
"The derived SqmFrom" + ( (AnonymousTupleType<?>) path.getReferencedPathSource() ).getComponentNames() + " can not be used in a context where the expression needs to " +
"be expanded to identifying parts, because a derived model part does not have identifying parts. " +
"Replace uses of the root with paths instead e.g. `derivedRoot.get(\"alias1\")` or `derivedRoot.alias1`"
);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
SemanticException.SemanticException
should be avoided because it has been deprecated.
@beikov beikov marked this pull request as ready for review October 15, 2024 15:29
public void tearDown(SessionFactoryScope scope){
scope.inTransaction(
session ->
session.createQuery( "delete from Book" ).executeUpdate()

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
QueryProducerImplementor.createQuery
should be avoided because it has been deprecated.
@beikov beikov merged commit 25ddb64 into hibernate:main Oct 18, 2024
24 of 27 checks passed
@beikov beikov deleted the HHH-18661 branch October 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant