-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18661 Add support for set-returning functions #9015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hibernate-core/src/main/java/org/hibernate/dialect/SpannerSqlAstTranslator.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/function/array/HANAUnnestFunction.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/function/array/HANAUnnestFunction.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/function/array/HANAUnnestFunction.java
Fixed
Show fixed
Hide fixed
...org/hibernate/query/sqm/function/AbstractSqmSelfRenderingSetReturningFunctionDescriptor.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/main/java/org/hibernate/dialect/JsonHelper.java
Dismissed
Show dismissed
Hide dismissed
| return "[]"; | ||
| } | ||
| final StringBuilder sb = new StringBuilder(); | ||
| final JsonAppender jsonAppender = new JsonAppender( sb ); |
Check warning
Code scanning / CodeQL
Potential output resource leak Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
449273a to
6c3479f
Compare
ae7a098 to
1e5ba2f
Compare
| addIdColumns( embeddableModelPart, idColumns ); | ||
| } | ||
| else { | ||
| throw new QueryException( "Unsupported model part container: " + modelPartContainer ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
QueryException.QueryException
| } | ||
|
|
||
| private String determineIndexSelectionExpression(SelectableMapping[] selectableMappings, String tableIdentifierVariable, TypeConfiguration typeConfiguration) { | ||
| final String defaultOrdinalityColumnName = typeConfiguration.getSessionFactory().getJdbcServices() |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
TypeConfiguration.getSessionFactory
| return visitTableGroup( resolved, sqmRoot ); | ||
| } | ||
|
|
||
| throw new InterpretationException( "SqmFunctionRoot not yet resolved to TableGroup" ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
InterpretationException.InterpretationException
| return visitTableGroup( existing, sqmJoin ); | ||
| } | ||
|
|
||
| throw new InterpretationException( "SqmFunctionJoin not yet resolved to TableGroup" ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
InterpretationException.InterpretationException
| throw new SemanticException( | ||
| "The derived SqmFrom" + ( (AnonymousTupleType<?>) path.getReferencedPathSource() ).getComponentNames() + " can not be used in a context where the expression needs to " + | ||
| "be expanded to identifying parts, because a derived model part does not have identifying parts. " + | ||
| "Replace uses of the root with paths instead e.g. `derivedRoot.get(\"alias1\")` or `derivedRoot.alias1`" | ||
| ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
SemanticException.SemanticException
…ed array support on more databases
| public void tearDown(SessionFactoryScope scope){ | ||
| scope.inTransaction( | ||
| session -> | ||
| session.createQuery( "delete from Book" ).executeUpdate() |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18730
https://hibernate.atlassian.net/browse/HHH-18661