replace checkstyle with something faster and simpler #9023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
force-pushed
the
nocheckstyle
branch
from
529445c to
f0f9deb
Compare
Member
Author
OK, screw it, I added a shit (but probably "good enough") implementation of UpperEll just because it was trivial. It doesn't handle comments correctly, but I doubt we care, and it would be very easy to add if we do. |
This is ~ 2 orders of magnitude faster on my machine, so it can be executed as part of the compileJava task. Also, it actually logs the failures, instead of making me go hunt for them in some generated HTML-based report.
gavinking
force-pushed
the
nocheckstyle
branch
from
f0f9deb to
461e868
Compare
Member
|
|
Member
Author
|
OK, then lemme see if I can implement a "good enough" EqualsHashcode without it slowing things down too much. I guess I probably can. |
Member
Author
Pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Competes with #9011.
This completely removes checkstyle, and enforces IllegalImport, RightCurly (UPDATE: and now UpperEll) via a simple line-based regex scan.
If @sebersole cares about EqualsHashCode
or UpperEll, I believe I can implement them too, using the exact same technology. Of course, EqualsHashCode probably can't be done quite perfectly using a regex, but it can certainly can be done in a way that's more than "good enough". (UpperEll can be implemented perfectly, since regexes are capable of tokenization.)