HHH-18675. Ignore generic, synthetic property in JPA-model #9029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
leonschenk
changed the title
leonschenk
changed the title
leonschenk
force-pushed
the
bugfix/HHH-18675
branch
from
45c1220 to
f8c46e2
Compare
…estcase without generics.
…o attribute for the jpa model.
leonschenk
force-pushed
the
bugfix/HHH-18675
branch
from
f8c46e2 to
bec085a
Compare
beikov
requested changes
Oct 2, 2024
Member
beikov
left a comment
beikov
left a comment
There was a problem hiding this comment.
The change looks good mostly, but please respect our code style.
hibernate-core/src/main/java/org/hibernate/metamodel/internal/MetadataContext.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/metamodel/internal/MetadataContext.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@beikov Thank you, I have changed your suggestions. |
beikov
approved these changes
Oct 2, 2024
Member
|
Yeah, please create a PR against the 6.6 branch. Please note that our license headers are slightly different on that branch though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hibernate should not map synthetic properties. However by copying the synthetic property the synthetic aspect is not copied. To circumvent this create a SyntheticProperty on copying. And ignore the property in the jpa-model.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18675