HHH-13547 - remove logging of BatchImpl rethrown exceptions #9039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
reviewed
Oct 3, 2024
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Thanks, added some comments -- though I fear I'm bringing more questions than solutions :)
hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/JdbcBatchLogging.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchImpl.java
Show resolved
Hide resolved
jrenaat
force-pushed
the
HHH-13547_batchlogging
branch
from
410c3d8 to
b089426
Compare
gavinking
requested changes
Oct 3, 2024
hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Schatteman <[email protected]>
jrenaat
force-pushed
the
HHH-13547_batchlogging
branch
from
b089426 to
856bcca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-13547