Skip to content

Conversation

@cigaly
Copy link
Contributor

@cigaly cigaly commented Oct 17, 2024

Jira issue HHH-18446

Fixing problem by adding (configurable) default SQL type code to LongVarbinaryJdbcType abd LongVarcharJdbcType

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 17, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@cigaly cigaly changed the title HHH-18446 HHH-18446 Cannot use @JdbcTypeCode(SqlTypes.LONG32VARBINARY) on field with null value Oct 17, 2024
@cigaly cigaly force-pushed the HHH-18446 branch 2 times, most recently from 4cfd4db to 0276a62 Compare October 23, 2024 14:14
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.

@gavinking
Copy link
Member

@cigaly why is this still in Draft mode?

@cigaly cigaly marked this pull request as ready for review October 23, 2024 20:50
@cigaly
Copy link
Contributor Author

cigaly commented Oct 23, 2024

Now I've switched back from draft mode

@gavinking
Copy link
Member

Actually, @cigaly can you squash that last commit please?

@gavinking gavinking merged commit bdc0070 into hibernate:main Oct 24, 2024
19 of 21 checks passed
@gavinking
Copy link
Member

Thank you so much! 🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants