Skip to content

Conversation

@mbellade
Copy link
Member

@mbellade mbellade commented Oct 24, 2024

https://hibernate.atlassian.net/browse/HHH-17612
https://hibernate.atlassian.net/browse/HHH-18762

Alternative solution to #9027, instead of creating new mappings for default revision entities we're creating new @MappedSuperclasses types which can be extended by both Envers and user's revision entities. Suggestions on the naming of these types are appreciated.

I also added to the migration guide and cleaned up the Envers user guide chapters about revision entities.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 24, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@sebersole
Copy link
Member

I'm not sure DefaultRevisionType is the default of anything. It seems to me the types here ought to be something like:

@MappedSuperclass
public class RevisionMapping {
    ...
}

@Entity
class DefaultRevisionEntity extends RevisionMapping {
    ...
}

@mbellade
Copy link
Member Author

Sure, so I've removed "default" for the two mapped-superclasses that had it in the name, and replaced "type" with "mapping" for all of them. LMK if there's anything else I should change.

Copy link
Member

@sebersole sebersole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sebersole sebersole merged commit 0378e59 into hibernate:main Nov 1, 2024
24 checks passed
@mbellade mbellade deleted the HHH-17612_2 branch March 17, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants