Skip to content

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented Nov 8, 2024

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18830

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 8, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [b92262e, cb61f92, 1904f18, 6274257, 7949e99]

› This message was automatically generated.

if ( manyToManyFilterHelper != null ) {
manyToManyFilterHelper.render( fragment, elementPersister.getFilterAliasGenerator( tableGroup ), enabledFilters );
manyToManyFilterHelper.render( fragment,
elementPersister.getFilterAliasGenerator( tableGroup ), enabledFilters );

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
elementPersister
may be null at this access as suggested by
this
null guard.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total false positive.

@gavinking gavinking changed the title HHH-18830 test demonstrating bug in @OrderColumn HHH-18830 fix extraneous updates for unowned List with @OrderColumn Nov 9, 2024
@gavinking gavinking merged commit d9a807f into hibernate:main Nov 10, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant