Fix .gitattributes / .gitignore
#9248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
sebersole
approved these changes
Nov 13, 2024
| # as some commands (git status, git add --renormalize) will still change its line endings to LF. | ||
| # So, we explicitly tell git not to mess with *.bat line endings. | ||
| # It's annoying as git won't show diffs for these files anymore, | ||
| # but that's the best I could come up with after an hour of head-scratching. |
Member
There was a problem hiding this comment.
These are always generated, so that's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our discussion here about the current
.gitattributesmessing up checked-in JAR files: https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/7.2E0.20Beta2.20.2F.206.2E6.2E2/near/481975242I think this matches @beikov 's original intent more closely, and is safer.
I also noticed a few conflicting/incorrect
.gitignorefiles, so I tried to fix what I could...By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.