HHH-16160 XML aggregate support for more databases #9256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

beikov merged 8 commits into hibernate:main from beikov:HHH-16160

Nov 22, 2024

Member

beikov commented Nov 14, 2024 •

edited

Loading

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-16160
https://hibernate.atlassian.net/browse/HHH-18799
https://hibernate.atlassian.net/browse/HHH-18800
https://hibernate.atlassian.net/browse/HHH-18801
https://hibernate.atlassian.net/browse/HHH-18802
https://hibernate.atlassian.net/browse/HHH-18803
https://hibernate.atlassian.net/browse/HHH-18804

github-advanced-security bot found potential problems

View reviewed changes

hibernate-core/src/main/java/org/hibernate/dialect/XmlHelper.java

    
              								// The end is the start angle bracket for the end tag

              								assert string.charAt( end ) == '<';

              								assert string.charAt( end + 1 ) == '/';

              								assert string.regionMatches( end + 2, tagName, 0, tagName.length() );

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

tagName

may be null at this access because of

this

assignment.
Variable

tagName

may be null at this access because of

this

assignment.

hibernate-core/src/main/java/org/hibernate/dialect/XmlHelper.java

    
              								// The end is the start angle bracket for the end tag

              								assert string.charAt( end ) == '<';

              								assert string.charAt( end + 1 ) == '/';

              								assert string.regionMatches( end + 2, tagName, 0, tagName.length() );

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

tagName

may be null at this access because of

this

assignment.
Variable

tagName

may be null at this access because of

this

assignment.

hibernate-core/src/main/java/org/hibernate/dialect/XmlHelper.java

    
              		final StringBuilder sb = new StringBuilder();

              		sb.append( START_TAG );

              		toString( embeddableMappingType, value, options, new XMLAppender( sb ) );

              		toString( embeddableMappingType, embeddableMappingType.getValues( value ), options, new XMLAppender( sb ) );

Check warning

Code scanning / CodeQL

Potential output resource leak Warning

This XMLAppender is not always closed on method exit.

hibernate-core/src/main/java/org/hibernate/dialect/XmlHelper.java

    
              			return EMPTY_COLLECTION_TAG;

              		}

              		final StringBuilder sb = new StringBuilder();

              		final XMLAppender xmlAppender = new XMLAppender( sb );

Check warning

Code scanning / CodeQL

Potential output resource leak Warning

This XMLAppender is not always closed on method exit.

hibernate-core/src/main/java/org/hibernate/dialect/XmlHelper.java Dismissed Show dismissed Hide dismissed

hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java

    
              	}

              	public static class SupportsXmlComponentUpdate implements DialectFeatureCheck {

              		public boolean apply(Dialect dialect) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides

DialectFeatureCheck.apply

; it is advisable to add an Override annotation.

beikov force-pushed the HHH-16160 branch from 6fcce7c to 17cfe59 Compare

November 15, 2024 11:36

hibernate-github-bot bot commented Nov 15, 2024 •

edited

Loading

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

beikov added the hana label

beikov force-pushed the HHH-16160 branch 3 times, most recently from 708d899 to 244ae8e Compare

November 20, 2024 12:02

github-advanced-security bot found potential problems

View reviewed changes

hibernate-core/src/main/java/org/hibernate/dialect/function/array/PostgreSQLUnnestFunction.java

    
              		}

              	}

              	protected void renderXmlTable(

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

UnnestFunction.renderXmlTable

; it is advisable to add an Override annotation.

beikov force-pushed the HHH-16160 branch 3 times, most recently from 1959fab to 478eef0 Compare

November 21, 2024 14:48

beikov added 8 commits

November 21, 2024 18:33


          HHH-16160 Fix some XML related issues that came up

58f43f0


          HHH-18804 Add XML aggregate support for HANA

dbff7b6


          HHH-18801 Add XML aggregate support for Sybase ASE

8ef5bfe


          HHH-18803 Add XML aggregate support for DB2

ed9652f


          HHH-18802 Add XML aggregate support for SQL Server

ac34b46


          HHH-18799 Add XML aggregate support for Oracle

616c939


          HHH-18800 Add XML aggregate support for PostgreSQL

97b343e


          HHH-16160 Fix some XML related issues that came up

a161a51

beikov force-pushed the HHH-16160 branch from 478eef0 to a161a51 Compare

November 21, 2024 17:33

beikov merged commit 9de9afe into hibernate:main

25 of 26 checks passed

beikov deleted the HHH-16160 branch

November 22, 2024 10:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hana