HHH-18867 correctly implement the documented semantics of beginTransaction() #9287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
changed the title
Member
Author
|
@sebersole WDYT? |
Member
|
I dislike changing the semantics here yet again. We've changed the semantics around But I agree this does match better with the JPA spec, so +1 |
sebersole
approved these changes
Nov 21, 2024
hibernate-core/src/main/java/org/hibernate/SharedSessionContract.java
Outdated
Show resolved
Hide resolved
beikov
approved these changes
Nov 28, 2024
and clarify its semantics in the jdoc
gavinking
force-pushed
the
tx-clarification
branch
from
eec7b8a to
4376d37
Compare
…PA method The JPA spec does not have anything to say about our beginTransaction() method
gavinking
force-pushed
the
tx-clarification
branch
from
4376d37 to
608b8b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and clarify its semantics in the jdoc
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.