fix some defects in repositories doc #9319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String title; | ||
| @Basic(optional = false) | ||
| LocalDate publicationDate; |
There was a problem hiding this comment.
I found LocalDate is in the scope of Basic at https://docs.jboss.org/hibernate/orm/6.6/userguide/html_single/Hibernate_User_Guide.html#basic-basic-annotation:
gavinking
requested changes
Nov 23, 2024
documentation/src/main/asciidoc/repositories/Configuration.adoc
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Nov 24, 2024
gavinking
reviewed
Nov 24, 2024
|
@NathanQingyangXu would you please squash this? |
NathanQingyangXu
force-pushed
the
improve-hibernate-data-doc
branch
from
7cf0ea7 to
3ca85ac
Compare
# Conflicts: # documentation/src/main/asciidoc/repositories/Repositories.adoc
NathanQingyangXu
force-pushed
the
improve-hibernate-data-doc
branch
from
4b735b2 to
ee648c1
Compare
done. |
gavinking
approved these changes
Aug 28, 2025
|
Merged via #10837 since there was a conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hibernate Data is definitively highly interesting to MongoDB Hibernate integration project for it provides a good selling point to compete with Spring Data Mongo (I used to be a lover of Spring Data's method name based query feature, now I found it is not well-founded and technically Hibernate Data is much more powerful and makes more sense).
I found some obvious defects in the doc, though there are some I am not certain of so I left some comments to confirm.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.