Skip to content

HHH-12997,HHH-9897 throw meaningful error for @JoinFomula with @OneToMany #9320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024
Merged

HHH-12997,HHH-9897 throw meaningful error for @JoinFomula with @OneToMany #9320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...te-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,10 +322,15 @@ public AbstractCollectionPersister(
keyColumnNames = new String[keySpan];
keyColumnAliases = new String[keySpan];
int k = 0;
for ( Column column: collectionBootDescriptor.getKey().getColumns() ) {
for ( Selectable selectable: collectionBootDescriptor.getKey().getSelectables() ) {
// NativeSQL: collect key column and auto-aliases
keyColumnNames[k] = column.getQuotedName( dialect );
keyColumnAliases[k] = column.getAlias( dialect, table );
keyColumnAliases[k] = selectable.getAlias( dialect, table );
if ( selectable instanceof Column column ) {
keyColumnNames[k] = column.getQuotedName( dialect );
}
else {
throw new MappingException("Collection keys may not contain formulas: " + navigableRole.getFullPath() );
}
k++;
}

Expand Down Expand Up @@ -374,7 +379,7 @@ public AbstractCollectionPersister(
elementFormulas[j] = form.getFormula();
}
else {
Column col = (Column) selectable;
final Column col = (Column) selectable;
elementColumnNames[j] = col.getQuotedName( dialect );
elementColumnWriters[j] = col.getWriteExpr( elementBootDescriptor.getSelectableType( factory, j ), dialect );
elementColumnReaders[j] = col.getReadExpr( dialect );
Expand Down
Loading