Skip to content

HHH-15102 allow -- style comments in native SQL query #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
Merged

HHH-15102 allow -- style comments in native SQL query #9336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,16 @@ public String perform() {

while ( tokens.hasMoreTokens() ) {
token = tokens.nextToken();
lcToken = token.toLowerCase(Locale.ROOT);

if ( "-".equals(token) && result.toString().endsWith("-") ) {
do {
result.append( token );
token = tokens.nextToken();
}
while ( !"\n".equals( token ) && tokens.hasMoreTokens() );
}

lcToken = token.toLowerCase(Locale.ROOT);
switch (lcToken) {

case "'":
Expand Down
6 changes: 6 additions & 0 deletions hibernate-core/src/test/java/org/hibernate/orm/test/sql/hand/query/NativeSQLQueriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,12 @@ public void testAddJoinForManyToMany(SessionFactoryScope scope) {
);
}

@Test @JiraKey( "HHH-15102" )
@SkipForDialect(dialectClass = MySQLDialect.class, matchSubTypes = true)
public void testCommentInSQLQuery(SessionFactoryScope scope) {
scope.inTransaction( s -> s.createNativeQuery( "select sum(1) --count(*), effectively\nfrom ORGANIZATION" ).getSingleResult() );
}

@Test
public void testTextTypeInSQLQuery(SessionFactoryScope scope) {
String description = buildLongString( 15000, 'a' );
Expand Down
Loading