Skip to content

Conversation

@beikov
Copy link
Member

@beikov beikov commented Nov 29, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-13377
https://hibernate.atlassian.net/browse/HHH-13790
https://hibernate.atlassian.net/browse/HHH-13815
https://hibernate.atlassian.net/browse/HHH-17612
https://hibernate.atlassian.net/browse/HHH-17838
https://hibernate.atlassian.net/browse/HHH-18168
https://hibernate.atlassian.net/browse/HHH-18274
https://hibernate.atlassian.net/browse/HHH-18360
https://hibernate.atlassian.net/browse/HHH-18361
https://hibernate.atlassian.net/browse/HHH-18362
https://hibernate.atlassian.net/browse/HHH-18363
https://hibernate.atlassian.net/browse/HHH-18364
https://hibernate.atlassian.net/browse/HHH-18365
https://hibernate.atlassian.net/browse/HHH-18367
https://hibernate.atlassian.net/browse/HHH-18369
https://hibernate.atlassian.net/browse/HHH-18384
https://hibernate.atlassian.net/browse/HHH-18583
https://hibernate.atlassian.net/browse/HHH-18629
https://hibernate.atlassian.net/browse/HHH-18689
https://hibernate.atlassian.net/browse/HHH-18709
https://hibernate.atlassian.net/browse/HHH-18850
https://hibernate.atlassian.net/browse/HHH-18868
https://hibernate.atlassian.net/browse/HHH-18872
https://hibernate.atlassian.net/browse/HHH-18903
https://hibernate.atlassian.net/browse/HHH-18904
https://hibernate.atlassian.net/browse/HHH-18906
https://hibernate.atlassian.net/browse/HHH-18932
https://hibernate.atlassian.net/browse/HHH-18949
https://hibernate.atlassian.net/browse/HHH-14725

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 29, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [4299df8, 466503f]

› This message was automatically generated.

Comment on lines +851 to +858
typeContributions.contributeType(
new JavaObjectType(
ObjectNullAsBinaryTypeJdbcType.INSTANCE,
typeContributions.getTypeConfiguration()
.getJavaTypeRegistry()
.getDescriptor( Object.class )
)
);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
TypeContributions.contributeType
should be avoided because it has been deprecated.
Comment on lines +189 to +192
String country = (String) session.createQuery(
"select e.country " +
"from Event e " +
"where e.id = :id and matches(e.country, :country) = 'T'" )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
QueryProducerImplementor.createQuery
should be avoided because it has been deprecated.
@beikov beikov force-pushed the 6.6-backports branch 2 times, most recently from 9e58e5b to bbd878e Compare December 3, 2024 08:14
Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@santschi
Copy link
Contributor

santschi commented Dec 3, 2024

Hey,

This PR seems to regress on the Jenkins notifications issue from a few weeks ago:
https://hibernate.zulipchat.com/#narrow/channel/132096-hibernate-user/topic/Jenkins.20Notifications

I am getting jenkins notifications again for:
https://ci.hibernate.org/job/hibernate-orm-quarkus/job/PR-9343/8/

@mbellade
Copy link
Member

mbellade commented Dec 6, 2024

Added #9262

@beikov beikov merged commit e685425 into hibernate:6.6 Dec 18, 2024
45 of 46 checks passed
@beikov beikov deleted the 6.6-backports branch December 18, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.