Skip to content

Conversation

@rusher
Copy link
Contributor

@rusher rusher commented Nov 29, 2024

Since 11.7 MariaDB support Vector fields.

This was in preview since some time, and now released since 11.7.1. see https://mariadb.org/projects/mariadb-vector/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18900

Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few test errors like:

  • java.sql.SQLException: (conn=151) Record has changed since last read in table 'EntityA'
  • BatchOptimisticLockingTest > testBatchAndOptimisticLocking: java.lang.AssertionError: expected:<class jakarta.persistence.OptimisticLockException> but was:<class org.hibernate.exception.GenericJDBCException>

which suggests that the new JDBC driver version behaves differently when reporting locking timeouts. Any idea what change that could have been?

@rusher
Copy link
Contributor Author

rusher commented Dec 9, 2024

Please hold on this PR for now. I'll take some time to make the test suite run with 11.7, but in a few weeks.
This will need specific investigation for each of them, like the optimistic test that fails because some new functionnality snapshot-isolation that might need to be handle in hibernate to throw the appropriate error.

@yrodiere yrodiere marked this pull request as draft December 12, 2024 16:14
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Dec 17, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@rusher
Copy link
Contributor Author

rusher commented Dec 18, 2024

yes, there is indeed an issue, i've created buildSQLExceptionConversionDelegate() method in MariaDBDialect class without getting the inherit MySQLDialect method. About the older mariadb version, they are still compatible with the test

@rusher
Copy link
Contributor Author

rusher commented Dec 18, 2024

this must now be ok.

@rusher rusher marked this pull request as ready for review December 18, 2024 23:45
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR

@rusher
Copy link
Contributor Author

rusher commented Dec 19, 2024

rebase done

+ adding support and test correction for mariadb 11.6.2 snapshot isolation
@rusher
Copy link
Contributor Author

rusher commented Dec 19, 2024

@beikov rebased after localtime fix, hoping that's the last time :)

@beikov beikov merged commit 65a26a2 into hibernate:main Dec 20, 2024
22 of 23 checks passed
@beikov
Copy link
Member

beikov commented Dec 20, 2024

Thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants