-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18900 MariaDB Vector support #9345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
beikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few test errors like:
java.sql.SQLException: (conn=151) Record has changed since last read in table 'EntityA'- BatchOptimisticLockingTest > testBatchAndOptimisticLocking:
java.lang.AssertionError: expected:<class jakarta.persistence.OptimisticLockException> but was:<class org.hibernate.exception.GenericJDBCException>
which suggests that the new JDBC driver version behaves differently when reporting locking timeouts. Any idea what change that could have been?
hibernate-core/src/test/java/org/hibernate/orm/test/temporal/MySQLTimestampFspFunctionTest.java
Outdated
Show resolved
Hide resolved
|
Please hold on this PR for now. I'll take some time to make the test suite run with 11.7, but in a few weeks. |
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchOptimisticLockingTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchUpdateAndVersionTest.java
Outdated
Show resolved
Hide resolved
...nate-core/src/test/java/org/hibernate/orm/test/query/hql/InsertConflictOnConstraintTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/optlock/OptimisticLockTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/function/json/JsonExistsTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/jpa/lock/LockExceptionTests.java
Show resolved
Hide resolved
|
yes, there is indeed an issue, i've created buildSQLExceptionConversionDelegate() method in MariaDBDialect class without getting the inherit MySQLDialect method. About the older mariadb version, they are still compatible with the test |
|
this must now be ok. |
beikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase the PR
|
rebase done |
+ adding support and test correction for mariadb 11.6.2 snapshot isolation
|
@beikov rebased after localtime fix, hoping that's the last time :) |
|
Thanks a lot for the contribution! |
Since 11.7 MariaDB support Vector fields.
This was in preview since some time, and now released since 11.7.1. see https://mariadb.org/projects/mariadb-vector/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18900