Skip to content

Conversation

@gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [b437a91]

› This message was automatically generated.

@gavinking gavinking merged commit 985740e into hibernate:main Nov 30, 2024
21 of 24 checks passed
def jsonbRuntimeVersion = version "jsonbRuntime", "3.0.4"
def jtaVersion = version "jta", "2.0.1"
def validationVersion = version "validation", "3.0.2"
def validationVersion = version "validation", "3.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @gavinking
I've noticed you've updated the Validation spec version. It probably doesn't matter that much since 3.1/3.0 are identical, but just in case, Hibernate Validator 8 is Jakarta Bean Validation 3.0 and Hibernate Validator 9 is targeting 3.1. There's a beta release of it available. And then if we bump validation to 3.1 we probably should also bump EL to 6.0 as well (at least that's the HV 9 relies on), it's currently set to 5.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK, thanks, I guess I should revert that then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that ... I don't know 😃
Jakarta validation 3.1 is part of Jakarta 11 so maybe we should keep it and bump the HV version to 9? In ORM HV is used only for tests, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well H9 is still in beta, so perhaps it's should wait.

In ORM HV is used only for tests, right?

Well there is integration code which depends on at least the spec jar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think I see what you mean: you're saying that HV itself is only used as in testing, even thought it's wrongly classified under libs instead of testLibs, and se we could use the beta release of H9 there. That makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants