HHH-18868 Wrong behaviour of getAttribute method in impl. of ManagedType when scattered id attributes are used in MappedSuperclass #9353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Who is going to review this? @mbladel I think you maybe understand this stuff? |
mbellade
reviewed
Dec 5, 2024
hibernate-core/src/main/java/org/hibernate/metamodel/internal/MetadataContext.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/metamodel/hhh18868/HHH18868Test.java
Outdated
Show resolved
Hide resolved
mbellade
reviewed
Dec 5, 2024
hibernate-core/src/main/java/org/hibernate/metamodel/internal/MetadataContext.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-18868
In
org.hibernate.metamodel.internal.MetadataContext#wrapUpid properties for mapped superclass are processed twice. First time withand second time in loop
and second value is replacing (at least on some places) first one. Additionally, first value has id flag set to true, second to false.
Proposed solution is checking if property has already been processed ad id property and skips those processed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.