HHH-18945 Hibernate Processor - fails if entity extends mapped superclass with same simple class name #9435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
requested changes
Dec 16, 2024
tooling/metamodel-generator/src/main/java/org/hibernate/processor/ClassWriter.java
Outdated
Show resolved
Hide resolved
…e simple class name
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
gavinking
reviewed
Dec 16, 2024
tooling/metamodel-generator/src/main/java/org/hibernate/processor/util/TypeUtils.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
Dec 16, 2024
tooling/metamodel-generator/src/main/java/org/hibernate/processor/util/TypeUtils.java
Outdated
Show resolved
Hide resolved
gavinking
approved these changes
Dec 17, 2024
Contributor
Author
|
BTW, should I squash those commits or leave that as is? |
Member
|
Squash please |
…ting other classes with same simple name
Contributor
Author
Done! |
Member
|
Thank you sir! |
Contributor
Author
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-18945
Simplified solution is to revert change in HHH-18693 so that superclass is always fully quylified when extended in meta model class.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.