HHH-18951 Support custom annotation attributes as configuration parameters of Generator

[quaff]

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

https://hibernate.atlassian.net/browse/HHH-18951

[quaff]

@gavinking Please review.

[gavinking]

Map<String,Object> is what we've just spent years trying to get away from.

[gavinking]

So I think this patch is in some sense perfectly fine and reasonable, but the thing is that Configurable, like the rest of the package it belongs to, is old stuff that we've already moved away from (except for the built-in generators). I don't think we should be giving it a second lease on life.

We moved to the new approach in order to achieve type safety, and this change undermines that.

So I guess I'm not really very keen on this.

[quaff]

We moved to the new approach in order to achieve type safety, and this change undermines that.

How about introduce a new functional interface accept the annotation before configure?

[beikov]

Please create PRs primarily against the main branch, especially if it's an improvement or new feature.

[quaff]

Please create PRs primarily against the main branch, especially if it's an improvement or new feature.

OK, should I create another PR or modify this one? I'd like it's fixed in 6.6.

[gavinking]

I'd like it's fixed in 6.6.

That's definitely not going to happen. 6.6 is finished and done.

But I'm not even convinced we should do this at all.

[quaff]

Alternatively, we could put the annotation self into parameters instead of its attributes.

[gavinking]

Alternatively, we could put the annotation self into parameters instead of its attributes.

That's certainly better.

[gavinking]

Well,

Alternatively, we could put the annotation self into parameters instead of its attributes.

That's certainly better.

Well, I dunno ... maybe not. It's somewhat more typesafe, at least.

[gavinking]

How about introduce a new functional interface accept the annotation before configure?

I think if we were going to do this, this would be the way, because the interface would be parameterized by the annotation type, and it would be type safe. But it means adding an additional interface and additional complexity for something that I'm just not convinced we have a great justification for.

[gavinking]

How about introduce a new functional interface accept the annotation before configure?

I think if we were going to do this, this would be the way, because the interface would be parameterized by the annotation type, and it would be type safe. But it means adding an additional interface and additional complexity for something that I'm just not convinced we have a great justification for.

Actually @quaff, I've been forgetting something. We already have an interface like this, and from looking at the code its initialize() method already gets called after a Generator is instantiated via the BeanContainer.

So I believe the functionality you're asking for already exists (and is even documented), I had just forgotten about it because I'm swapped-out on this stuff.

[quaff]

How about introduce a new functional interface accept the annotation before configure?

I think if we were going to do this, this would be the way, because the interface would be parameterized by the annotation type, and it would be type safe. But it means adding an additional interface and additional complexity for something that I'm just not convinced we have a great justification for.

Actually @quaff, I've been forgetting something. We already have an interface like this, and from looking at the code its initialize() method already gets called after a Generator is instantiated via the BeanContainer.

So I believe the functionality you're asking for already exists (and is even documented), I had just forgotten about it because I'm swapped-out on this stuff.

My bad, you are right.

[quaff]

and is even documented

@gavinking The document mentioned AnnotationBasedGenerator, it should elaborate for such user case.