HHH-18714 add support for inheritance in NamedEntityGraph annotation #9539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
requested changes
Jan 2, 2025
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
Thanks so much, that was quick!
I left some very minor comments/suggestions, mainly just code formatting (I think some whitespace got messed in the redo).
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
Jan 2, 2025
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
Ugh. two more minor suggestions I missed the first time around. I might have been misreading the diff, actually. Sorry!
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@gavinking Ah sorry, the codestyle for Hibernate didn't apply on my intellij. Everything should be fine now |
Contributor
Author
|
Surprisingly, the hibernate-style code but the @SuppressWarnings annotations on the same lines as the variable declarations |
gavinking
approved these changes
Jan 2, 2025
Member
|
Thank you @Asanio06 !! |
Contributor
Author
|
Thanks for the support for this first contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
This MR is the continuation of this one #9088 .
The aim is to make inheritance work on Entity graphs, as described in the NamedEntityGraph annotation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18714