HHH-19005 Reduce memory usage for JSON string literals in BasicFormatterImpl #9545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
changed the title
beikov
force-pushed
the
feature/HHH-19005
branch
from
1ff49aa to
259a9bb
Compare
gavinking
requested changes
Feb 11, 2025
hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Feb 11, 2025
hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/BasicFormatterImpl.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
dev3way
force-pushed
the
feature/HHH-19005
branch
from
53ef8d7 to
5703a00
Compare
Contributor
Author
|
@gavinking Is there any other things to check? |
gavinking
approved these changes
Feb 11, 2025
Member
|
Please fix the code style errors: https://github.com/hibernate/hibernate-orm/actions/runs/13266304414/job/37035063848?pr=9545 |
dev3way
force-pushed
the
feature/HHH-19005
branch
3 times, most recently
from
6653578 to
72ea36d
Compare
Contributor
Author
|
@gavinking @beikov Modified code style and commit message. Please, review again this pr |
dev3way
force-pushed
the
feature/HHH-19005
branch
2 times, most recently
from
72ea36d to
15678d4
Compare
Contributor
Author
|
@gavinking @beikov Could you please check and merge? |
beikov
force-pushed
the
feature/HHH-19005
branch
from
15678d4 to
b29ef41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19005
Hello.
When It is json, there are some memory leak.
These are the results of the modified code and the existing code when tested locally.
In the case above, there is no problem elsewhere, but the problem occurs at the point where JSON data is encountered after VALUES. From this point on, a String is created in the above code for all tokenized JSON data, creating a memory leak. This means that the larger the JSON, the more leaks it will create.
This problem doesn't normally occur, but it makes a difference if you are performing json. This occurs when tokenizing json and formatting it while passing the switch statement within the perform method. Therefore, it seems better to change this code to StringBuilder as shown below.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.