Skip to content

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented Jan 4, 2025

introduce EventListenerGroups

See https://hibernate.atlassian.net/browse/HHH-19008

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jan 4, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [6217e7b, 38bb804, c319db0]

› This message was automatically generated.

@Override
protected boolean hasPostCommitEventListeners() {
for ( PostDeleteEventListener listener: getFastSessionServices().eventListenerGroup_POST_COMMIT_DELETE.listeners() ) {
for ( PostDeleteEventListener listener: getEventListenerGroups().eventListenerGroup_POST_COMMIT_DELETE.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
|| eventListenerGroups.eventListenerGroup_POST_COMMIT_DELETE.count() > 0
|| eventListenerGroups.eventListenerGroup_POST_DELETE.count() > 1
|| eventListenerGroups.eventListenerGroup_POST_DELETE.count() == 1
&& !(eventListenerGroups.eventListenerGroup_POST_DELETE.listeners().iterator().next()

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.

@Internal @Incubating // find a new home for this operation
public final FormatMapper getJsonFormatMapper() {
return getSessionFactory().getSessionFactoryOptions().getJsonFormatMapper();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
TypeConfiguration.getSessionFactory
should be avoided because it has been deprecated.

@Internal @Incubating // find a new home for this operation
public final FormatMapper getXmlFormatMapper() {
return getSessionFactory().getSessionFactoryOptions().getXmlFormatMapper();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
TypeConfiguration.getSessionFactory
should be avoided because it has been deprecated.
Comment on lines +32 to +34
context.getBootstrapContext().getClassLoaderService()
.classForName( auxDbObjectImplClass )
.newInstance();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Class.newInstance
should be avoided because it has been deprecated.
@gavinking gavinking changed the title Clean up FastSessionServices which had become a bucket to dump things in HHH-19008 Clean up FastSessionServices which had become a bucket to dump things in Jan 4, 2025
@gavinking gavinking merged commit bc5e3ce into hibernate:main Jan 4, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant