-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19017: Address ClassCastException for PersistentAttributeInterceptable #9605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimsimon-wk! Just left a few minor comments, but other than that your change looks good to me.
...main/java/org/hibernate/sql/results/graph/entity/internal/EntityDelayedFetchInitializer.java
Outdated
Show resolved
Hide resolved
...-core/src/test/java/org/hibernate/orm/test/lazyonetoone/LazyOneToOneWithEntityGraphTest.java
Outdated
Show resolved
Hide resolved
...-core/src/test/java/org/hibernate/orm/test/lazyonetoone/LazyOneToOneWithEntityGraphTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
620a985 to
ca7c629
Compare
|
Thanks for the helpful review @mbladel! I thought I had imported the codestyles to IntelliJ, but I must have forgotten to apply formatting. This moved things around a little in the unit test too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems your last commit has a typo i.e. you used HHH-19107 instead of HHH-19017 in the commit message. After fixing that, the PR can IMO be merged.
353fe18 to
a0e1fbf
Compare
TIL about |
|
@beikov CI failed on codestyles, so I had to push more updates. Are you able to start the workflow again? Is there a timeline yet on when we can expect this to merge and get released? |
|
@jimsimon-wk could you please squash all commits to a single one (or one for the test and another for the fix)? After that we can go ahead and merge. |
da54329 to
096682a
Compare
@mbladel No problem. The branch should now be one commit after my last push |
|
@beikov @mbladel I’m facing the same issue after updating to the newest Spring Boot Would you please be so kind to apply this fix to the |
|
I already backported this via #9921 |
A
ClassCastExceptionis thrown when trying to resolve instances without bytecode enhancement enabled under these preconditions:Related Change in Hibernate 6.6
Reproducer
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19017