Skip to content

Various code cleanup #9631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 34 commits into from
Closed

Various code cleanup #9631

wants to merge 34 commits into from

Conversation

@sebersole
Copy link
Member

@sebersole sebersole commented Jan 16, 2025

Various code cleanup

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jan 16, 2025 •
edited
Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [79dcb2f, 2a4a447, f02f461, 56c0372, b6154f3, 45f2a59, a0f982c, eeb10d5, cee9470, 7497c2b, dca1a97, a329bf6, 13b447d, 9281a48, 2d42f3f, 53dda34, 022d85d, f6d98a7, fde950f, 5445b17, e6dad59, 8a9a80d, 04f1b83, 9194625, 415a7b7, d47f0cb, 5d82744, 3f61c65, 0c4c641, 96faa42, b4dd2c8, 9b96e6a, 846c648, 0f85112]

› This message was automatically generated.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 16, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 12, 2025
View reviewed changes
...nate-core/src/test/java/org/hibernate/orm/test/jpa/criteria/nestedfetch/NestedFetchTest.java
final Root<Customer> fromRoot = criteria.from( Customer.class );
final Fetch<Customer, Order> ordersFetch = fromRoot.fetch( "orders", JoinType.LEFT );
final Fetch<Order, OrderLine> linesFetch = ordersFetch.fetch( "lines", JoinType.LEFT );
final Fetch<OrderLine, Product> productFetch = linesFetch.fetch( "product", JoinType.LEFT );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Fetch<OrderLine,Product> productFetch' is never read.
.../src/test/java/org/hibernate/orm/test/persister/entity/CustomSqlNamespaceInjectionTests.java
verifyDmlSql( sessionFactoryScope, persister, expectedTableName );
}

private static void verifyDmlSql(SessionFactoryScope sessionFactoryScope, EntityPersister persister, String expectedTableName) {

Check notice

Code scanning / CodeQL

Useless parameter Note test

The parameter 'sessionFactoryScope' is never used.
@sebersole
Copy link
Member Author

sebersole commented Feb 20, 2025

Applied this manually

@sebersole sebersole closed this Feb 20, 2025
@sebersole sebersole deleted the code-cleanups branch February 20, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sebersole