Various changes around dialects #9638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
Member
Author
|
@loiclefevre Please review commit a4ee850 and let me know if there's anything you disagree with or if I broke something. Thanks! |
to make the flow here a bit clearer
even if this is maybe not *precisely* the intent of DialectSpecificSettings
make things explicit that were implicit
note: system properties are already included in Environment properties
Looks like this has not worked since probably H 6.0 The issue here is that the test for this feature was one of these tests written to look at the Hibernate metamodel and not at the actual DDL that was ultimately generated. This is why I despise "unit" testing instead of testing actual user-visible functionality. Anyway this was an undocumented feature so it can just be removed.
gavinking
force-pushed
the
orarefactor
branch
from
4c3ddfb to
688c8b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.