Skip to content

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented Jan 22, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18998

@yrodiere
Copy link
Member

yrodiere commented Oct 6, 2025

@gavinking was there any concern about this? Just wanting to discuss it with someone else maybe?

@gavinking
Copy link
Member Author

If I recall correctly, I was not completely happy with it.

@yrodiere
Copy link
Member

yrodiere commented Oct 6, 2025

I will schedule discussing this with the team

@sebersole
Copy link
Member

I like it!

@sebersole
Copy link
Member

sebersole commented Oct 21, 2025

I think I may be missing the "config" aspect though? I was assuming you'd do something like:

@Entity
class Thing {
    ...
    @Stuff(config="abc")
    Stuff stuff;
}

@Type(StuffType.class)
@interface Stuff {
    String config();
}

class StuffType implements UserType<Stuff> {
    /** Constructor injection  */
    StuffType(Stuff annotation) {...}

    /** Or contract injection */
    void configure(Stuff annotation) { ... }
}

But I'm not seeing the injection bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants