Renaming AuthorBookRecord in documentation #9671
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
|
@sebersole @gavinking if this PR is correct, can we get a jira to pass the build? |
| Naturally, the name and type of the parameter are still checked at compile time; there's no loss of typesafety here, despite the string. | ||
|
|
||
| The `@Param` annotation is significantly less useful, since we can always rename our HQL query parameter to match the method parameter, or, at worst, use an ordinal parameter instead. | ||
| The `@Param` annotation is significantly less useful, since we can always rename our HQL query parameter to match the method parameter, or, at worst, use an ordinal parameter instead. |
There was a problem hiding this comment.
@cunhazera What changed here ... the lines look identical.
There was a problem hiding this comment.
@gavinking no idea... I don't see any differences in any diff checker except GitHub's. But I can send a new commit trying to undo this change.
|
@gavinking I dont know if I have permission to create a jira ticket to move this forward. Can I get an assistance here? |
Everyone should have permission to create an issue in JIRA, but we don't need one for documentation fixes. But would you please squash those commits? |
cunhazera
force-pushed
the
main
branch
2 times, most recently
from
8e5ba1d to
e219ec1
Compare
|
@gavinking I messed up with the squash. Just submitted a new one: #9760 |
2 participants
Renaming AuthorBookRecord to AuthorBookSummary
The documentation uses a class name as example, called
AuthorBookSummary, but later on there is a new class calledAuthorBookRecordI wonder if
AuthorBookSummaryshould be the class name used in the record declaration and in the implementation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.