Skip to content

Conversation

@gsmet
Copy link
Member

@gsmet gsmet commented Feb 6, 2025

Backport of #9699 to 6.6.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19104

@jin-harmoney
Copy link

@yrodiere any idea why the test compilation failed? I checked the pipeline output, but I don't see an immediate link with the changes in the PR.

@yrodiere
Copy link
Member

yrodiere commented Feb 6, 2025

> Task :hibernate-core:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API that is marked for removal.
Note: Recompile with -Xlint:removal for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
compiler message file broken: key=compiler.misc.msg.bug arguments=11.0.12, {1}, {2}, {3}, {4}, {5}, {6}, {7}
java.lang.AssertionError: isSubtype UNKNOWN
	at jdk.compiler/com.sun.tools.javac.code.Types$4.visitType(Types.java:1123)
	at jdk.compiler/com.sun.tools.javac.code.Types$4.visitType(Types.java:1100)
	at jdk.compiler/com.sun.tools.javac.code.Type.accept(Type.java:214)
	at jdk.compiler/com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:4857)
	at jdk.compiler/com.sun.tools.javac.code.Types.isSubtype(Types.java:1096)
	at jdk.compiler/com.sun.tools.javac.code.Types.isSubtypeUncheckedInternal(Types.java:1022)

This happens on the s390x build, which uses OpenJ9, so it's either something in this PR that doesn't work with OpenJ9, or something failing already on the target branch, or simply something wrong on the worker node. I need to check.

@yrodiere
Copy link
Member

yrodiere commented Feb 6, 2025

Let's see what happens on #9704

@yrodiere
Copy link
Member

yrodiere commented Feb 6, 2025

Let's see what happens on #9704

Same problem there, so it's unrelated. Let's wait for the remaining builds to complete (Quarkus, TCK) and then merge.

@yrodiere yrodiere merged commit edeb19a into hibernate:6.6 Feb 7, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants