HHH-19116 Error when using fk() function on left joined many-to-one association and is null predicate #9769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the check for `fk()` function argument type
beikov
reviewed
Feb 18, 2025
Member
There was a problem hiding this comment.
I don't have a strong opinion on adding support for fk( alias ) in addition to fk( alias.toOneAttribute ). Mixing the bug-fix with a feature makes backporting harder though, so maybe separate the two concerns into dedicated commits maybe?
EDIT: Just saw you did split into dedicated commits. Sorry for the fuzz.
...nate-core/src/test/java/org/hibernate/orm/test/query/LeftJoinNullnessPredicateQueryTest.java
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/associations/NotFoundTest.java
Show resolved
Hide resolved
beikov
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19116
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.