-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19115 - implement ordered multiloading with natural ids #9783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-19115 - implement ordered multiloading with natural ids #9783
Conversation
...rnate-core/src/main/java/org/hibernate/loader/ast/internal/AbstractMultiNaturalIdLoader.java
Outdated
Show resolved
Hide resolved
6fd66cc to
0100465
Compare
0100465 to
2d3c30f
Compare
176dbff to
1092ed5
Compare
| } | ||
|
|
||
| @Test | ||
| @SkipForDialectGroup( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This skip blocks here and below are a bit confusing IMO as there is no javadoc comment on why the skips are necessary. Also, I'm a bit surprised that a multi-load of 3 composite natural ids only requires 3 parameters. What is rendered SQL for this? I would expect this always requires 6 parameters i.e. where (ssn,ssn2) in ( (?,?), (?,?), (?,?) ) because tuples can't be passed as a single parameter AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex that i'm using for the tests that exclude Sybase, SQLServer, DB2 and hsqldb are looking at the (?,?) pattern, ergo, it checks whether there are 3
Sybase, SQLServer, DB2 and hsqldb produce different sql queries that effectively contain 6 '?', but using MultiKeyLoadHelper.supportsSqlArrayType for this didn't do the trick
I'll add a comment to the tests to clarify this.
545a1ad to
0ee5465
Compare
|
@beikov Wrt to our conversation in zulip, i checked whether using a @DialectFeatureCheck as you suggested would be viable, but IMHO it isn't because I don't have acccess for now to the element that differentiates the dialects; it would be much uglier to hack something than to just leave the test as it was conceived. |
2030b2e to
b5b62ec
Compare
(also corrected a couple of typo's I came across) Signed-off-by: Jan Schatteman <[email protected]>
b5b62ec to
14b5e9a
Compare
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19115