HHH-18546 Clean up any hanging BulkOperationCleanupAction after-txn callbacks on Session close #9812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this( DefaultCacheKeysFactory.INSTANCE, properties ); | ||
| } | ||
|
|
||
| public TestCachingRegionFactory(CacheKeysFactory cacheKeysFactory, Properties properties) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
beikov
reviewed
Mar 4, 2025
hibernate-core/src/main/java/org/hibernate/engine/spi/ActionQueue.java
Outdated
Show resolved
Hide resolved
|
Hey @dreab8 , any reason this wasn't merged? Should we close the PR or do you intend to rebase it and/or resume work? |
|
Hi @yrodiere really cannot remeber :( |
|
We should IMO rebase and merge this once CI passes. |
…allbacks on Session close
beikov
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18546
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.