Skip to content

Conversation

@marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HHH-19210
https://hibernate.atlassian.net/browse/HV-1267

and while at it ... I've updated the BV-related tests to JUnit 5


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@marko-bekhta marko-bekhta force-pushed the fix/HHH-19210-Change-how-the-ValidationMode-AUTO-behaves branch from 3aa224d to 157cb72 Compare February 28, 2025 10:01
@marko-bekhta marko-bekhta force-pushed the fix/HHH-19210-Change-how-the-ValidationMode-AUTO-behaves branch from 157cb72 to 227317f Compare March 4, 2025 11:15
@marko-bekhta
Copy link
Member Author

rebased and added a migration note, since we are changing the default behaviour for the validator integration, and users might want to know about that? 😃

@marko-bekhta marko-bekhta force-pushed the fix/HHH-19210-Change-how-the-ValidationMode-AUTO-behaves branch from 227317f to caa9bc9 Compare March 14, 2025 20:32
@sebersole
Copy link
Member

LGTM. I am resolving the conflicts and then I'll apply :)

@sebersole
Copy link
Member

sebersole commented Mar 20, 2025

[[validator-integration-auto]]
=== ValidationMode#AUTO

Previously, Hibernate would silently treat `ValidationMode#AUTO` as `ValidationMode#NONE` when either:

* there were no providers available
* a provider was available, but creating an instance of the `ValidatorFactory` resulted in an exception.

Starting in 7.0, when a provider is available but creating the `ValidatorFactory` results in an exception, that exception is now propagated (re-thrown).

wdyt?

(its part of the overall "Changes in Behavior" section)

@marko-bekhta
Copy link
Member Author

+1 that's better and to the point 😃 thanks! (just is it "Starting in 7.0" or "Starting with 7.0"? )

@sebersole
Copy link
Member

Actually, how about just -

Starting with 7.0, when a provider is available but creating the `ValidatorFactory` results in an exception, that exception is now propagated (re-thrown).

(personally I think with/in are equally appropriate, but ...)

@marko-bekhta
Copy link
Member Author

works for me 😃

@sebersole
Copy link
Member

Applied the changes we discussed, squashed and manually applied.

Thanks @marko-bekhta !

@sebersole sebersole closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants