Skip to content

Conversation

@marko-bekhta
Copy link
Member

@marko-bekhta marko-bekhta commented Feb 28, 2025

Hey @mbladel
I was looking at some tests that failed in the other PR and noticed that this one fails on sybase with:

OneToOneLazyOrphanRemovalEmbeddedTest > initializationError FAILED
    org.hibernate.exception.GenericJDBCException: could not execute statement [Incorrect syntax near the keyword 'count'.
    ] [insert into OwnerEntity (child_id,count,id) values (?,?,?)]
        at app//org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:61)

https://github.com/hibernate/hibernate-orm/actions/runs/13576066171/job/37952476819?pr=9822

IDK if the tests should just quote the keywords or what the general approach is, but since... I suppose this test wasn't really about keywords, maybe let's just rename the property/column and make the build happier ? 😄


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19185

Copy link
Member

@mbellade mbellade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@mbellade mbellade merged commit 6598ab6 into hibernate:main Feb 28, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants