migration guide structure #9866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
migration-guide.adoc
Outdated
| * Removed `MetadataContributor` -> `AdditionalMappingContributor` | ||
| * Removed `EmptyInterceptor` -> implement `org.hibernate.Interceptor` directly | ||
| * Removed `Session.LockRequest` -> use `LockOptions` | ||
| * See also, |
There was a problem hiding this comment.
Suggested change
| * See also, |
👀 👀 👀 👀 I'm looking buuut ...
migration-guide.adoc
Outdated
| ** Removed `Session.save` in favor of `Session.persist` | ||
| ** Removed `Session.saveOrUpdate` in favor `persist` if the entity is transient or `merge` if the entity is detached | ||
| ** Removed `Session.update` in favor of `Session.merge` | ||
| ** Removed `org.hibernate.annotations.CascadeType.SAVE_UPDATE` in favor of `org.hibernate.annotations.CascadeType.PERSIST` + `org.hibernate.annotations.CascadeType.MERGE` |
There was a problem hiding this comment.
Suggested change
| ** Removed `org.hibernate.annotations.CascadeType.SAVE_UPDATE` in favor of `org.hibernate.annotations.CascadeType.PERSIST` + `org.hibernate.annotations.CascadeType.MERGE` | |
| ** Removed `org.hibernate.annotations.CascadeType.SAVE_UPDATE` in favor of `org.hibernate.annotations.CascadeType.PERSIST` and `org.hibernate.annotations.CascadeType.MERGE` |
with + it looks like the formatting got broken, so maybe use words instead?
|
Thanks for looking! I'm more thinking that Removals section really needs a big overhaul. |
sebersole
force-pushed
the
migration-guide
branch
from
63687e6 to
9b3ea72
Compare
scottmarlow
reviewed
Mar 20, 2025
marko-bekhta
approved these changes
Mar 20, 2025
sebersole
force-pushed
the
migration-guide
branch
from
e3194e2 to
0b6f76c
Compare
|
Applied this manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some preliminary work. Really not happy with the
Removalssection, but need to give that some more thought.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.