-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19319, HHH-19318 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple() #9959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-19319, HHH-19318 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple() #9959
Conversation
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
|
@DavideD Can you please take a look at this and see if it impacts Reactive, please? Thanks! |
| */ | ||
| void lock(Object id, Object version, Object object, int timeout, EventSource session) | ||
| throws StaleObjectStateException, LockingStrategyException; | ||
| default void lock(Object id, Object version, Object object, int timeout, SharedSessionContractImplementor session) |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
OptimisticForceIncrementLockingStrategy.lock
Method LockingStrategy.lock(..) could be confused with overloaded method
OptimisticLockingStrategy.lock
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
multiLoad
I will |
|
Yes, there are a couple of compilation errors, but nothing critical: DavideD/hibernate-reactive@2dbbe16 I haven't checked if we need to mimic some of the changes you've made in reactive, though |
Excellent, thanks.
Ummmm ... at most you would need to change some occurrences of |
…and duplicated logic
cc @jrenaat
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19318