Skip to content

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented Apr 4, 2025

cc @jrenaat

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19318

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Apr 4, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [bdc1aa9, 32c4c1a, ffa17f0, 6a6fb0b, 826f5e9, 3855c77, 36a0f0d, af17285]

› This message was automatically generated.

@gavinking
Copy link
Member Author

@DavideD Can you please take a look at this and see if it impacts Reactive, please?

Thanks!

*/
void lock(Object id, Object version, Object object, int timeout, EventSource session)
throws StaleObjectStateException, LockingStrategyException;
default void lock(Object id, Object version, Object object, int timeout, SharedSessionContractImplementor session)

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method LockingStrategy.lock(..) could be confused with overloaded method
OptimisticForceIncrementLockingStrategy.lock
, since dispatch depends on static types.
Method LockingStrategy.lock(..) could be confused with overloaded method
OptimisticLockingStrategy.lock
, since dispatch depends on static types.

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method AbstractEntityPersister.multiLoad(..) could be confused with overloaded method
multiLoad
, since dispatch depends on static types.
@DavideD
Copy link
Member

DavideD commented Apr 4, 2025

@DavideD Can you please take a look at this and see if it impacts Reactive, please?

Thanks!

I will

@DavideD
Copy link
Member

DavideD commented Apr 4, 2025

Yes, there are a couple of compilation errors, but nothing critical: DavideD/hibernate-reactive@2dbbe16

I haven't checked if we need to mimic some of the changes you've made in reactive, though

@gavinking
Copy link
Member Author

Yes, there are a couple of compilation errors, but nothing critical

Excellent, thanks.

I haven't checked if we need to mimic some of the changes you've made in reactive, though

Ummmm ... at most you would need to change some occurrences of EventSource to SharedSessionContractImplementor.

@gavinking gavinking changed the title generalize loaders to handle stateless sessions HHH-19319 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple Apr 4, 2025
@gavinking gavinking changed the title HHH-19319 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple HHH-19319 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple() Apr 4, 2025
@gavinking gavinking merged commit 0a4d551 into hibernate:main Apr 4, 2025
22 of 25 checks passed
@gavinking gavinking changed the title HHH-19319 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple() HHH-19319, HHH-19318 generalize loaders to handle stateless sessions, add StatelessSession.findMultiple() Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants