Skip to content

HHH-19321: Improve inline documentation for @SuppressWarnings in multiple methods #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

HHH-19321: Improve inline documentation for @SuppressWarnings in multiple methods #9966

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e0b603
[HHH-19321] Add inline documentation for @SuppressWarnings usage in r…
plan11plan Apr 6, 2025
fafe1ed
[HHH-19321] Add inline documentation for @SuppressWarnings usage in g…
plan11plan Apr 6, 2025
d284ad9
[HHH-19321] Add inline documentation for @SuppressWarnings usage in u…
plan11plan Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureCallImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,8 @@ public Query<R> setOrder(Order<? super R> order) {
// Parameter registrations

@Override
@SuppressWarnings("unchecked")
@SuppressWarnings("unchecked") // This suppression is used to suppress unchecked conversion warnings that occur when converting a raw Class to a generic type.
// The underlying call to registerParameter is type-safe, so ignoring this warning is acceptable.
public ProcedureCallImplementor<R> registerStoredProcedureParameter(int position, Class type, ParameterMode mode) {
getSession().checkOpen( true );

Expand All @@ -443,7 +444,8 @@ public ProcedureCallImplementor<R> registerStoredProcedureParameter(int position
}

@Override
@SuppressWarnings("unchecked")
@SuppressWarnings("unchecked") // This suppression is used to suppress unchecked conversion warnings that occur when converting a raw Class to a generic type.
// The underlying call to registerParameter is type-safe, so ignoring this warning is acceptable.
public ProcedureCallImplementor<R> registerStoredProcedureParameter(
String parameterName,
Class type,
Expand Down Expand Up @@ -990,7 +992,10 @@ protected ScrollableResultsImplementor<R> doScroll(ScrollMode scrollMode) {
}

@Override
@SuppressWarnings("unchecked")
@SuppressWarnings("unchecked") // This suppression is used to suppress unchecked conversion warnings in two cases:
// 1. Returning Collections.EMPTY_LIST, which is a raw type, as a List<R>.
// 2. Casting the result of ResultSetOutput.getResultList() to List<R>.
// Both conversions are considered safe based on the intended usage.
public List<R> getResultList() {
if ( getMaxResults() == 0 ) {
return Collections.EMPTY_LIST;
Expand Down Expand Up @@ -1060,7 +1065,9 @@ else if ( resultList.size() > 1 ) {
}

@Override
@SuppressWarnings("unchecked")
@SuppressWarnings("unchecked") // This suppression is used to suppress unchecked cast warnings occurring when casting 'this', parameterMetadata,
// paramBindings, queryOptions, getSession(), or getOutputs() to the desired generic type T.
// Each cast is checked using cls.isInstance() or isAssignableFrom(), ensuring that the conversion is safe.
public <T> T unwrap(Class<T> cls) {
if ( cls.isInstance( this ) ) {
return (T) this;
Expand Down