Skip to content

Conversation

@marko-bekhta
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@marko-bekhta marko-bekhta requested a review from mbellade April 8, 2025 09:13
@mbellade
Copy link
Member

mbellade commented Apr 8, 2025

Thanks @marko-bekhta. This would make sense as a one-of test but, since there's no easy way to do that, I'd say we might keep the additional logs and the trim() changes without moving them before the release type check?

Copy link
Member

@mbellade mbellade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, let's keep the logs for now.

@mbellade mbellade merged commit 65cf39b into hibernate:main Apr 8, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants