Some fixes for JPA TCK failures #9988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI @gavinking, this reverts a part of what you have done in hibernate#8866 which causes JPA TCK test failure of ee.jakarta.tck.persistence.core.entityManager2.Client2.lockTransactionRequiredExceptionTest
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| public NamedGraphCreatorJpa(NamedEntityGraph annotation, String jpaEntityName) { | ||
| this.name = NullnessHelper.coalesceSuppliedValues( annotation::name, () -> jpaEntityName ); | ||
| final String name = StringHelper.nullIfEmpty( annotation.name() ); |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
| //noinspection unchecked | ||
| final EntityDomainType<T> entityDomainType = (EntityDomainType<T>) entityDomainNameResolver.apply( jpaEntityName ); | ||
| return GraphParsing.parse( entityDomainType, graphContext.attributeList(), entityNameResolver ); | ||
| final String name = this.name == null ? jpaEntityName : this.name; |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
| //noinspection unchecked | ||
| final EntityDomainType<T> entityDomainType = (EntityDomainType<T>) entityDomainClassResolver.apply( (Class<T>) entityType ); | ||
| return GraphParsing.parse( entityDomainType, graphContext.attributeList(), entityNameResolver ); | ||
| final String name = this.name == null ? entityDomainType.getName() : this.name; |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
gavinking
reviewed
Apr 9, 2025
|
|
||
| private void checkTransactionNeededForLock(LockMode lockMode) { | ||
| if ( !LockMode.PESSIMISTIC_READ.greaterThan( lockMode ) ) { | ||
| if ( lockMode.greaterThan( LockMode.READ ) ) { |
There was a problem hiding this comment.
Yep, thanks, good catch, @beikov.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.